While trying to update DGM, i still got some languages missing :
Profit / Loss :
Missing translation for Profit in french and german
Toil / Trouble :
Missing french translation for Trouble
Do you mean gatherer is missing foreign names for card having one (such as those examples) or are you only talking about cards that never were printed in some languages ?
Basically, Gatherer doesn't have that data.
Gatherer doesn't have foreign names for a large number of cards. In these cases they show the English name where the translation should be. I don't show the translation if the foreign name is identical to the English card name, because 99% of the time it's not correct and would balloon the size of the JSON files quite significantly.
So thats the situation. I hear that magiccards.info has more complete translations (and up to date promos/fnm cards) but I'm hesitant to scrape from them without permission. I've contacted them but have not yet heard anything back.
For cards in Planar Chaos, would there be any way to distinguish Timeshifted cards? This would be useful in any kind of pack simulator. Making new rarities for these cards seems a bit much, but maybe there could be something like timeshifted=true on these cards. You could also do this for Future Sight, although the timeshifted layout on those cards had no effect on booster pack contents.
For cards in Planar Chaos, would there be any way to distinguish Timeshifted cards? This would be useful in any kind of pack simulator. Making new rarities for these cards seems a bit much, but maybe there could be something like timeshifted=true on these cards. You could also do this for Future Sight, although the timeshifted layout on those cards had no effect on booster pack contents.
Thanks for the suggestion! I just updated the site with this, so FUT, PLC and TSB all have timeshifted set to true where appropriate
So I just noticed something weird randomly, and I'm not sure what it's about, but the flavor text on Bloodshot Trainee is missing the exclamation point after "Hrrngh". I remeber seeing a missing exclamation point in another card's flavor text too. This isn't your fault, though, that's how Gatherer has it also, so I'm not sure if there's anything you can really do about it if it's prevalent at all.
This prompted me to check the card Kaboom!, and it has the exclamation point in its name, but on the card text, it's missing! What's going on? Again, this is true on Gatherer and in MTG-JSON. Not all exclamation points are missing, though, I found several flavor texts that still had them.
So I just noticed something weird randomly, and I'm not sure what it's about, but the flavor text on Bloodshot Trainee is missing the exclamation point after "Hrrngh". I remeber seeing a missing exclamation point in another card's flavor text too. This isn't your fault, though, that's how Gatherer has it also, so I'm not sure if there's anything you can really do about it if it's prevalent at all.
This prompted me to check the card Kaboom!, and it has the exclamation point in its name, but on the card text, it's missing! What's going on? Again, this is true on Gatherer and in MTG-JSON. Not all exclamation points are missing, though, I found several flavor texts that still had them.
Sorry for the delay in responding, I'm on vacation and have HORRIBLE internet.
Yup, looks like you found some more gatherer bugs. The exclamation points are totally missing on gatherer. Not in the HTML code at all.
This isn't too surprising as MTGJSON corrects multiple gatherer mistakes already.
magiccards.info correctly has the exclamation marks.
I'll be doing some work in a few weeks to add all promos and tokens to MTGJSON. I'll be getting this data from magiccards.info. While I'm doing that, I'll do write some code to compare the flavor text of cards between gatherer/mtgjson and magiccards.info which will help me detect gatherer errors I haven't caught yet. I'll verify that it is indeed a gatherer error and I'll correct the mistake in mtgjson.
I won't be doing this for a few weeks (late august, early september) so I'll let you know once it's finally done
All tokens should have the 'layout' field set to 'token'. I plan on adding the rest of the tokens to the sets in a few weeks, but they too will have the layout field set to token.
So just filter out any cards that have "token" for their "layout" field.
In the parser I wrote, I convert all non-ASCII characters to their ASCII equivalents (though Niv-Mizzet's flavor text might have to be an exception), and I found these odd characters:
Nonbreaking space (0x00A0) in Sanguine Praetor's flavor text
Line separator (0x2028) in Battle Hurda's flavor text
Horizontal Bar (0x2015) in Beast Within's flavor text (Heroes vs. Monsters) and in Orcish Lumberjack's (Heros vs. Monsters and Vintage Masters.) The two versions of the Lumberjack actually have their flavor text formatted differently on Gatherer, the VM one has a linebreak (and MTG-JSON doesn't pick up the quote attribution there.)
Sorry to keep finding bugs, and thanks a lot for all the hard work you've put into this project!
All tokens should have the 'layout' field set to 'token'. I plan on adding the rest of the tokens to the sets in a few weeks, but they too will have the layout field set to token.
So just filter out any cards that have "token" for their "layout" field.
Awesome!
Where are you getting additional token information, they're not hidden on Gatherer are they?
In the parser I wrote, I convert all non-ASCII characters to their ASCII equivalents (though Niv-Mizzet's flavor text might have to be an exception), and I found these odd characters:
Nonbreaking space (0x00A0) in Sanguine Praetor's flavor text
Line separator (0x2028) in Battle Hurda's flavor text
Horizontal Bar (0x2015) in Beast Within's flavor text (Heroes vs. Monsters) and in Orcish Lumberjack's (Heros vs. Monsters and Vintage Masters.) The two versions of the Lumberjack actually have their flavor text formatted differently on Gatherer, the VM one has a linebreak (and MTG-JSON doesn't pick up the quote attribution there.)
Sorry to keep finding bugs, and thanks a lot for all the hard work you've put into this project!
I'll take care of these too, at the same time I do the full flavor check of all cards. That means waiting a few weeks until I get back home, I hope that's ok. I will also be correcting any artist mistakes I can find.
Don't be sorry about finding bugs! It's a good thing! Thank you!!! It'll help make MTGJSON better and better
I'll take care of these too, at the same time I do the full flavor check of all cards. That means waiting a few weeks until I get back home, I hope that's ok. I will also be correcting any artist mistakes I can find.
Don't be sorry about finding bugs! It's a good thing! Thank you!!! It'll help make MTGJSON better and better
Thanks! A couple other things you might be interested in:
1. In flavor texts that have quotations with attributions, such as Dissipation Field's '"Strike me once, shame on you. Strike me twice . . . Well, let's just see if you can." —Kara Vrist, Neurok agent', an em dash (U+2014) is used, but I think the convention is to use that horizontal bar character (U+2015) I mentioned earlier that strangely showed up on like 2 cards. (Related info on this)
2. Niv-Mizzet's flavor text is probably supposed to have a degree sign (U+00B0), but for some reason uses a "Masculine Ordinal Indicator" sign (U+00BA); these look identical in some renderings but not in others.
Not sure if this has been asked previously - is there any support in your data for FNM and other promo cards, to distinguish them from the regular variants of those cards?
Private Mod Note
():
Rollback Post to RevisionRollBack
Minouris's Library - Collection manager and deck builder. It's nifty - Check it out!
Thanks! A couple other things you might be interested in:
1. In flavor texts that have quotations with attributions, such as Dissipation Field's '"Strike me once, shame on you. Strike me twice . . . Well, let's just see if you can." —Kara Vrist, Neurok agent', an em dash (U+2014) is used, but I think the convention is to use that horizontal bar character (U+2015) I mentioned earlier that strangely showed up on like 2 cards. (Related info on this)
2. Niv-Mizzet's flavor text is probably supposed to have a degree sign (U+00B0), but for some reason uses a "Masculine Ordinal Indicator" sign (U+00BA); these look identical in some renderings but not in others.
Not sure if this has been asked previously - is there any support in your data for FNM and other promo cards, to distinguish them from the regular variants of those cards?
Right now the only promo cards I have are in the PPR set. I will be adding FNM, media inserts and other promo cards in a few weeks. I'll be adding these into new sets called "Friday Night Magic", "Media Inserts", etc. So the way to distinguish these cards as promos is the fact that they are in these promo sets (the "type" field of the set object will be set to "promo").
Right now the only promo cards I have are in the PPR set. I will be adding FNM, media inserts and other promo cards in a few weeks. I'll be adding these into new sets called "Friday Night Magic", "Media Inserts", etc. So the way to distinguish these cards as promos is the fact that they are in these promo sets (the "type" field of the set object will be set to "promo").
Nifty, thanks man
Private Mod Note
():
Rollback Post to RevisionRollBack
Minouris's Library - Collection manager and deck builder. It's nifty - Check it out!
I will be adding all promo cards in a few weeks to MTGJSON. I will be getting this info from magiccards.info as I am not aware of any other place online for this data. I am a little worried that magiccards.info may not be updated anymore (still doesn't have M15) so if anyone knows another up to date source of promo info, please let me know.
Here is how magiccards.info has them (the 'set code' is in parenthesis at the end):
15th Anniversary (15ANN)
Grand Prix (GPX)
Pro Tour (PRO)
Magic Game Day Cards (MGDC)
Worlds (WRL)
World Magic Cup Qualifiers (WMCQ)
Dragon Con (DRC)
Prerelease Events (PTC)
Release Events (REP)
Magic: The Gathering Launch Parties (MLP)
Summer of Magic (SUM)
WPN/Gateway (GRC)
Champs (CP)
Two-Headed Giant Tournament (THGT)
Arena League (ARENA)
Friday Night Magic (FNMP)
Magic Player Rewards (MPRP)
Super Series (SUS)
Happy Holidays (HHO)
Judge Gift Program (JR)
Portal Demogame (POT)
European Land Program (EURO)
Guru (GURU)
Asia Pacific Land Program (APAC)
WotC Online Store (WOTC)
Celebration Cards (UQC)
Media Inserts (MBP)
Legend Membership (DCILM)
I feel that dividing the promo cards into the sets is a good way to go. I also think the set names they have are good (anyone disagree?). I thought about creating a single 'Promo' set and putting every card in there, but I don't think that's the right way to go.
I have an issue with the set codes.
Notice they range in length from 2 to 5 letters. I'm not sure I like this length variablity. Right now on MTGJSON all set codes are exactly 3 letters in length. While I'd like to keep it that way, I feel that if I use 3 letter codes for the new sets (aka FNM for Friday Night Magic), there is a good chance a future MTG expansion might have the same code and then I'd have to change the set code which I want to avoid having to do at all costs.
So I am leaning towards 4 letters. A three letter code for the set, with a 'P' prefix or suffix (for 'Promo'). So "Friday Night Magic" would be 'PFNM' or 'FNMP'. For "Prerelease Events" 'PREP' or 'PPRE'. Some software that uses MTGJSON that has set codes hardcoded to 3-letters would need to be updated, but I feel like that's better than having to deal with potential future set code conflicts.
What are everyones thoughts on this?
I would also likely do away with the 'PPR' set from MTGJSON. This is a set gatherer used for Promo cards a while ago, but hasn't updated in years. All the cards in that set can be found in the sets detailed above and I don't want two sets that have the 'identical' same card. I would of couse ensure that the multiverseid is carried over with the card to whichever set each card finds itself.
Also the 'HHO' set that I have on MTGJSON would be renamed to whatever is decided on (PHHO or HHOP, etc)
Where the individual cards are associated with a regular set (such as prerelease cards), will there be any way to link a card with the set it's derived from? For example, the foil, watermarked Goblin Rabblethingy that was released as the Buy-A-Box promo card for M15, and still has the M15 set symbol...
Private Mod Note
():
Rollback Post to RevisionRollBack
Minouris's Library - Collection manager and deck builder. It's nifty - Check it out!
Would JSON allow you to write the codes as P-FNM? I think that would be the clearest way to show that they are promo sets. It would break the 4 character rule, though.
Where the individual cards are associated with a regular set (such as prerelease cards), will there be any way to link a card with the set it's derived from? For example, the foil, watermarked Goblin Rabblethingy that was released as the Buy-A-Box promo card for M15, and still has the M15 set symbol...
The magiccards.info site has a 'comment' field where they list assorted info as to where the card actually came from or is linked to. So for Grand Prix cards it lists the year, and for Prerelease events, it lists what expansion it was for. I plan on bringing that information along, as a new field for the card (not sure if I'll call it 'comment' or 'note' or something else).
Beyond that, I think determining which set it belongs to is as simple as finding the first non-promo set released that has a card with the same name. That would be an easy exercise for the consumer of the JSON to perform if they needed that linking.
Would JSON allow you to write the codes as P-FNM? I think that would be the clearest way to show that they are promo sets. It would break the 4 character rule, though.
Yes, JSON would allow this, it wouldn't pose a problem. The 4 character rule isn't really a rule, it was just an arbitrary number I chose. So introducing a dash delimiter wouldn't be an issue for the JSON at all and I agree it does make it a bit more evident that this isn't a normal set, that it's a classification done above and beyond what Wizards releases. It may of course impact software and apps that consume the JSON which is why I felt it was important to solicit feedback before I introduce the promo cards
Looks like you're renaming the three letter code for Summer of Magic from (SUM) to (SOM). Won't this conflict with Scars of Mirrodin?
Your post illustrates exactly why it shouldn't be just a 3 letter code for these sets. Maybe my post wasn't clear enough, but I was suggesting a final code of PSOM or P-SOM or SOMP or SOM-P. Although I am fine with keeping it SUM instead of SOM. It's just that to avoid future conflicts it can't just be SUM. It's gotta be 4 or more letters in order to ensure no future conflicts and to show that the set isn't an official one.
Basically, I am seeking opinion on the naming convention for the set codes.
Private Mod Note
():
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
Basically, Gatherer doesn't have that data.
Gatherer doesn't have foreign names for a large number of cards. In these cases they show the English name where the translation should be. I don't show the translation if the foreign name is identical to the English card name, because 99% of the time it's not correct and would balloon the size of the JSON files quite significantly.
So thats the situation. I hear that magiccards.info has more complete translations (and up to date promos/fnm cards) but I'm hesitant to scrape from them without permission. I've contacted them but have not yet heard anything back.
Thanks for the suggestion! I just updated the site with this, so FUT, PLC and TSB all have timeshifted set to true where appropriate
So I just noticed something weird randomly, and I'm not sure what it's about, but the flavor text on Bloodshot Trainee is missing the exclamation point after "Hrrngh". I remeber seeing a missing exclamation point in another card's flavor text too. This isn't your fault, though, that's how Gatherer has it also, so I'm not sure if there's anything you can really do about it if it's prevalent at all.
This prompted me to check the card Kaboom!, and it has the exclamation point in its name, but on the card text, it's missing! What's going on? Again, this is true on Gatherer and in MTG-JSON. Not all exclamation points are missing, though, I found several flavor texts that still had them.
Also I've made my first post specifically exploring the MTG JSON data.
http://rednaxela1618.wordpress.com/2014/07/24/weird-facts-from-mtg-json-first-letters/
Sorry for the delay in responding, I'm on vacation and have HORRIBLE internet.
Yup, looks like you found some more gatherer bugs. The exclamation points are totally missing on gatherer. Not in the HTML code at all.
This isn't too surprising as MTGJSON corrects multiple gatherer mistakes already.
magiccards.info correctly has the exclamation marks.
I'll be doing some work in a few weeks to add all promos and tokens to MTGJSON. I'll be getting this data from magiccards.info. While I'm doing that, I'll do write some code to compare the flavor text of cards between gatherer/mtgjson and magiccards.info which will help me detect gatherer errors I haven't caught yet. I'll verify that it is indeed a gatherer error and I'll correct the mistake in mtgjson.
I won't be doing this for a few weeks (late august, early september) so I'll let you know once it's finally done
Thanks for letting me know about this
All tokens should have the 'layout' field set to 'token'. I plan on adding the rest of the tokens to the sets in a few weeks, but they too will have the layout field set to token.
So just filter out any cards that have "token" for their "layout" field.
Nonbreaking space (0x00A0) in Sanguine Praetor's flavor text
Line separator (0x2028) in Battle Hurda's flavor text
Horizontal Bar (0x2015) in Beast Within's flavor text (Heroes vs. Monsters) and in Orcish Lumberjack's (Heros vs. Monsters and Vintage Masters.) The two versions of the Lumberjack actually have their flavor text formatted differently on Gatherer, the VM one has a linebreak (and MTG-JSON doesn't pick up the quote attribution there.)
Sorry to keep finding bugs, and thanks a lot for all the hard work you've put into this project!
Awesome!
Where are you getting additional token information, they're not hidden on Gatherer are they?
I will be getting them from: http://magiccards.info/extras.html
I'll take care of these too, at the same time I do the full flavor check of all cards. That means waiting a few weeks until I get back home, I hope that's ok. I will also be correcting any artist mistakes I can find.
Don't be sorry about finding bugs! It's a good thing! Thank you!!! It'll help make MTGJSON better and better
You are welcome! Glad you find it a useful resource. Let me know if you run into any issues or need anything else
Thanks! A couple other things you might be interested in:
1. In flavor texts that have quotations with attributions, such as Dissipation Field's '"Strike me once, shame on you. Strike me twice . . . Well, let's just see if you can." —Kara Vrist, Neurok agent', an em dash (U+2014) is used, but I think the convention is to use that horizontal bar character (U+2015) I mentioned earlier that strangely showed up on like 2 cards. (Related info on this)
2. Niv-Mizzet's flavor text is probably supposed to have a degree sign (U+00B0), but for some reason uses a "Masculine Ordinal Indicator" sign (U+00BA); these look identical in some renderings but not in others.
Not sure if this has been asked previously - is there any support in your data for FNM and other promo cards, to distinguish them from the regular variants of those cards?
Minouris's Library - Collection manager and deck builder. It's nifty - Check it out!
Thanks again. Will also look into these too
Right now the only promo cards I have are in the PPR set. I will be adding FNM, media inserts and other promo cards in a few weeks. I'll be adding these into new sets called "Friday Night Magic", "Media Inserts", etc. So the way to distinguish these cards as promos is the fact that they are in these promo sets (the "type" field of the set object will be set to "promo").
Nifty, thanks man
Minouris's Library - Collection manager and deck builder. It's nifty - Check it out!
https://rednaxela1618.wordpress.com/2014/08/03/weird-facts-from-mtg-json-converted-mana-cost/
(This post also shows off the usefulness of the layout information for stripping out unusual cards.)
I need some feedback and I am seeking opinions.
I will be adding all promo cards in a few weeks to MTGJSON. I will be getting this info from magiccards.info as I am not aware of any other place online for this data. I am a little worried that magiccards.info may not be updated anymore (still doesn't have M15) so if anyone knows another up to date source of promo info, please let me know.
Here is how magiccards.info has them (the 'set code' is in parenthesis at the end):
I feel that dividing the promo cards into the sets is a good way to go. I also think the set names they have are good (anyone disagree?). I thought about creating a single 'Promo' set and putting every card in there, but I don't think that's the right way to go.
I have an issue with the set codes.
Notice they range in length from 2 to 5 letters. I'm not sure I like this length variablity. Right now on MTGJSON all set codes are exactly 3 letters in length. While I'd like to keep it that way, I feel that if I use 3 letter codes for the new sets (aka FNM for Friday Night Magic), there is a good chance a future MTG expansion might have the same code and then I'd have to change the set code which I want to avoid having to do at all costs.
So I am leaning towards 4 letters. A three letter code for the set, with a 'P' prefix or suffix (for 'Promo'). So "Friday Night Magic" would be 'PFNM' or 'FNMP'. For "Prerelease Events" 'PREP' or 'PPRE'. Some software that uses MTGJSON that has set codes hardcoded to 3-letters would need to be updated, but I feel like that's better than having to deal with potential future set code conflicts.
What are everyones thoughts on this?
I would also likely do away with the 'PPR' set from MTGJSON. This is a set gatherer used for Promo cards a while ago, but hasn't updated in years. All the cards in that set can be found in the sets detailed above and I don't want two sets that have the 'identical' same card. I would of couse ensure that the multiverseid is carried over with the card to whichever set each card finds itself.
Also the 'HHO' set that I have on MTGJSON would be renamed to whatever is decided on (PHHO or HHOP, etc)
For 3 letter set codes I was thinking:
Thoughts?
I'd love some feedback and opinions on this.
Thanks!
Where the individual cards are associated with a regular set (such as prerelease cards), will there be any way to link a card with the set it's derived from? For example, the foil, watermarked Goblin Rabblethingy that was released as the Buy-A-Box promo card for M15, and still has the M15 set symbol...
Minouris's Library - Collection manager and deck builder. It's nifty - Check it out!
The magiccards.info site has a 'comment' field where they list assorted info as to where the card actually came from or is linked to. So for Grand Prix cards it lists the year, and for Prerelease events, it lists what expansion it was for. I plan on bringing that information along, as a new field for the card (not sure if I'll call it 'comment' or 'note' or something else).
Beyond that, I think determining which set it belongs to is as simple as finding the first non-promo set released that has a card with the same name. That would be an easy exercise for the consumer of the JSON to perform if they needed that linking.
Yes, JSON would allow this, it wouldn't pose a problem. The 4 character rule isn't really a rule, it was just an arbitrary number I chose. So introducing a dash delimiter wouldn't be an issue for the JSON at all and I agree it does make it a bit more evident that this isn't a normal set, that it's a classification done above and beyond what Wizards releases. It may of course impact software and apps that consume the JSON which is why I felt it was important to solicit feedback before I introduce the promo cards
My Cube Blog @theCubeMiser on Twitter
Your post illustrates exactly why it shouldn't be just a 3 letter code for these sets. Maybe my post wasn't clear enough, but I was suggesting a final code of PSOM or P-SOM or SOMP or SOM-P. Although I am fine with keeping it SUM instead of SOM. It's just that to avoid future conflicts it can't just be SUM. It's gotta be 4 or more letters in order to ensure no future conflicts and to show that the set isn't an official one.
Basically, I am seeking opinion on the naming convention for the set codes.