Thanks Sembiance! Maybe you can continue to offer legacy support, but also allow users to tweak parameters in the source code for new features. Then they can self-scrape Gatherer and get the desired results. I recall you planned to make the source code "friendlier" too...
I found another bug, this one's kind of weird: In all versions of Jade Statue except for the Ninth Edition one, they have power and toughness values present (as 3/6). Gatherer has it this way too. How strange.
I too think the double linefeed is unnecessary, in the parser I wrote I convert them all to single linefeeds. However, I understand the difficulty in choosing between what's best and what you've always done when it comes to designing a system like this.
I found another bug, this one's kind of weird: In all versions of Jade Statue except for the Ninth Edition one, they have power and toughness values present (as 3/6). Gatherer has it this way too. How strange.
Since you already host the card images, I don't suppose there'd be any chance you'd additionally host the mana symbol images and expansion symbol images?
Since you already host the card images, I don't suppose there'd be any chance you'd additionally host the mana symbol images and expansion symbol images?
So I got permission from BaconCatBug to put his/her work up on the site, but after thinking about it some more I've decided not to.
The SVG and PNG files he/she provides are already awesome and so I don't think I would be adding very much by hosting them.
Everyone will need different image formats and sizes anyways, so I would need to provide multiple formats and sizes and updating the site every time a new set comes out would be more work.
Since the SVG and PNG files already provided by BaconCatBug are so awesome, I don't think adding them up to mtgimage or mtgjson will be that useful.
I have updated both mtgjson and mtgimage with links to the symbol threads so users can find them easily
Kudos to you, Sembiance. I'm using this in my project now. Its a real breeze to use, so 10 thousand thanks
As I am beginning to use angularJS personally/professionally, I thought I'd write a simple directive to render card text and casting cost. Pretty much just made the repo, so I still need to do examples/instructions (and frankly the css could be better), but it can be found here: https://github.com/omnihound/magic-symbol-directive
Since the SVG and PNG files already provided by BaconCatBug are so awesome, I don't think adding them up to mtgimage or mtgjson will be that useful.
Well, it would make caching a bit better. Eg.: someone visit an other mtgimg user's site, then he visit mine, the browser can use the same set icons on my site from the cache. It's a tiny factor, but well its useful.
Also, can you please add Expire headers to the images? Google's analysis tool (PageSpeed insights) keeps bugging me because there is no expire time set on the images.
As I am beginning to use angularJS personally/professionally, I thought I'd write a simple directive to render card text and casting cost. Pretty much just made the repo, so I still need to do examples/instructions (and frankly the css could be better), but it can be found here: https://github.com/omnihound/magic-symbol-directive
That css is really cool! Much better than my old img way.
Also, can you please add Expire headers to the images? Google's analysis tool (PageSpeed insights) keeps bugging me because there is no expire time set on the images.
Whoops!
It used to have one, but I must have made a change at some point and it must have gotten lost.
I have fixed it, and now the images have a far-future expires date.
All cards in the 'extras' files now have 'originalText' and 'originalType' fields. These contain the original non-oracle text and type that was on the card at the time it was printed.
Also updated all cards in all sets so that they have the latest oracle text, oracle type and rulings.
The set 'Commander' has been re-named to 'Magic: The Gathering-Commander' to match the official set name and to match what has always been in the 'printings' field of cards.
Each set object now has a 'booster' property describing it's booster pack properties. See the Booster Field documentation for more details.
The 'colors' field is no longer present on cards that have no colors (it used to be present, but as an empty array)
<set>
<shortname>dgm</shortname>
<id>0</id>
<game>0</game>
<block>0</block>
<codename>Sinker</codename>
<count>
<cardcount>156</cardcount>
<commoncount>70</commoncount>
<uncommoncount>40</uncommoncount>
<rarecount>35</rarecount>
<mythicrarecount>11</mythicrarecount>
</count>
<mechanic>
<cycle>Split Cards with Fuse</cycle>
<cycle>Guildgates</cycle>
<cycle>Gatekeepers</cycle>
<theme>Guilds</theme>
<theme>Guildmarks</theme>
</mechanic>
<designers>
<designer>
<id>12</id>
<position>Lead</position>
</designer>
<designer>
<id>0</id>
</designer>
<designer>
<id>14</id>
</designer>
<designer>
<id>33</id>
</designer>
<designer>
<id>17</id>
</designer>
<designer>
<id>48</id>
</designer>
</designers>
<developers>
<developer>
<id>5</id>
<position>Lead</position>
</developer>
<developer>
<id>14</id>
</developer>
<developer>
<id>6</id>
</developer>
<developer>
<id>19</id>
</developer>
<developer>
<id>49</id>
</developer>
<developer>
<id>50</id>
</developer>
</developers>
<deck>
<!-- Unused, place for the intro packs -->
</deck>
<prerelease>
<start>April 27, 2013</start>
<end>April 28, 2013</end>
</prerelease>
<release>
<start>May 3, 2013</start>
</release>
<launchparty>
<start>May 3, 2013</start>
<end>May 6, 2013</end>
</launchparty>
<onlinerelease>
<start>May 13, 2013</start>
</onlinerelease>
<protour>
<start>May 17, 2013</start>
<end>May 19, 2013</end>
</protour>
<gameday>
<start>May 25, 2013</start>
<end>May 26, 2013</end>
</gameday>
<langdata>
<lang langid="0">
<name>Dragon's Maze</name>
<flavor>A massive puzzle spans the city-world of Ravnica, and all ten guilds race to be the first to crack the mystery. Rumors abound that whoever navigates the maze of clues could command world-shaking power. Will your guild take the prize?</flavor>
</lang>
<lang langid="1">
<name></name>
<flavor></flavor>
</lang>
<lang langid="2">
<name></name>
<flavor></flavor>
</lang>
<lang langid="3">
<name></name>
<flavor></flavor>
</lang>
<lang langid="4">
<name></name>
<flavor></flavor>
</lang>
<lang langid="5">
<name></name>
<flavor></flavor>
</lang>
<lang langid="6">
<name></name>
<flavor></flavor>
</lang>
<lang langid="7">
<name></name>
<flavor></flavor>
</lang>
<lang langid="8">
<name></name>
<flavor></flavor>
</lang>
<lang langid="9">
<name></name>
<flavor></flavor>
</lang>
</langdata>
</set>
All sets up to Gatecrash in XMLs. My friend did this for me a while back. (It was costed me some money...) I can voluntary give this info for you if you can add it. The developers/designers are mapped into their own xml files (developers.xml and designers.xml). The flavors and other texts come from wizard's set info. (http://www.wizards.com/magic/tcg/productarticle.aspx?x=mtg/tcg/gatecrash/productinfo) The foreign language flavors was not added because the was unneeded at that time and would cost a lot of effort to add correctly. Also the intropacks/eventdecks missing sadly.
All sets up to Gatecrash in XMLs. My friend did this for me a while back. (It was costed me some money...) I can voluntary give this info for you if you can add it. The developers/designers are mapped into their own xml files (developers.xml and designers.xml). The flavors and other texts come from wizard's set info. (http://www.wizards.com/magic/tcg/productarticle.aspx?x=mtg/tcg/gatecrash/productinfo) The foreign language flavors was not added because the was unneeded at that time and would cost a lot of effort to add correctly. Also the intropacks/eventdecks missing sadly.
Hello
Thanks for the offer to provide more set info. At this time I'm not sure how much more set info I want to add. I originally wanted to focus mostly on just the cards. I'll need to think a bit about how much data I want to add to the sets
All sets up to Gatecrash in XMLs. My friend did this for me a while back. (It was costed me some money...) I can voluntary give this info for you if you can add it. The developers/designers are mapped into their own xml files (developers.xml and designers.xml). The flavors and other texts come from wizard's set info. (http://www.wizards.com/magic/tcg/productarticle.aspx?x=mtg/tcg/gatecrash/productinfo) The foreign language flavors was not added because the was unneeded at that time and would cost a lot of effort to add correctly. Also the intropacks/eventdecks missing sadly.
Hello
Thanks for the offer to provide more set info. At this time I'm not sure how much more set info I want to add. I originally wanted to focus mostly on just the cards. I'll need to think a bit about how much data I want to add to the sets
Okey, no problem. What I need is a big, robust MTG database at this point. At the moment the data for this comes from various sources (mtgjson, my xmls and so on). I like the life simple so using one datasource would be a lot easier, and maybe someone else want to use this stuff too. If you ever plan to implement this setinfo just write me a PM.
Could you post your XML files so that we could at least take a look? I'm a contributor to the SlightlyMagic.net pictures project and documenting things accurately is always an interest of ours
Just a quick update. I updated MTGJSON with a new field. 'gathererCode' has been added to sets where the code on gatherer is different than the standard 3 letter 'code'.
I've noticed that, for some reason, M14 is called "Magic 2014 Core Set", but M10 through M13 don't have the "Core Set" in their names. It seems like Gatherer adds that onto the name of the newest one, but is this something that should be kept?
Also, about the "Promo Set for Gatherer": you might not want to include this set. It's not even a real thing, I'm not sure why it even exists in Gatherer. It looks like it contains all the old book promos like Mana Crypt, which is nice (obviously you can't just leave these cards out of a database), but then it also has all the prerelease cards up into Fifth Dawn for some reason. Have you considered doing anything about this?
I've noticed that, for some reason, M14 is called "Magic 2014 Core Set", but M10 through M13 don't have the "Core Set" in their names. It seems like Gatherer adds that onto the name of the newest one, but is this something that should be kept?
Up to this point I've made sure that the MTGJSON set names match exactly what Gatherer uses.
When 'Magic 2015' is released, we will see whether they drop the 'Core Set' suffix from 'Magic 2014' or not.
It's possible they have decided to just start adding 'Core Set' suffix to all core sets going forward, and they started with 'Magic 2014'.
We'll see in July
For now, I'm going to keep the set names as they are.
Also, about the "Promo Set for Gatherer": you might not want to include this set. It's not even a real thing, I'm not sure why it even exists in Gatherer. It looks like it contains all the old book promos like Mana Crypt, which is nice (obviously you can't just leave these cards out of a database), but then it also has all the prerelease cards up into Fifth Dawn for some reason. Have you considered doing anything about this?
You are correct that the 'Promo Set for Gatherer' is a bit of a mess. It doesn't even have all the promo cards, not even close. Gatherer also doesn't update it as far as I can tell.
I added the set and cards because I had multiple requests to do so.
I'd rather leave the data up, rather than take it down as people do use it, despite it's issues.
The data isn't harming anyone, as you easily enough choose to ignore that set
Private Mod Note
():
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
What do you suggest if one also wants the format legality of a card?
Edit:
Well I'll be... http://www.wizards.com/Magic/Magazine/Article.aspx?x=judge/resources/banned
I too think the double linefeed is unnecessary, in the parser I wrote I convert them all to single linefeeds. However, I understand the difficulty in choosing between what's best and what you've always done when it comes to designing a system like this.
I have fixed this and updated the site. Thanks!
Others have also asked for this
It's a matter of finding a source for the images.
I'm aware of the great work BaconCatBug has done here: http://forums.mtgsalvation.com/showthread.php?t=522919
However it feels a bit wrong to just take his/her work and host it up on the site without asking for permission first (which I haven't done yet).
Just thinking out loud... maybe they wouldn't mind, since I'd give them full credit of course.
Edit: I went ahead and asked him/her. We'll see
The SVG and PNG files he/she provides are already awesome and so I don't think I would be adding very much by hosting them.
Everyone will need different image formats and sizes anyways, so I would need to provide multiple formats and sizes and updating the site every time a new set comes out would be more work.
Since the SVG and PNG files already provided by BaconCatBug are so awesome, I don't think adding them up to mtgimage or mtgjson will be that useful.
I have updated both mtgjson and mtgimage with links to the symbol threads so users can find them easily
As I am beginning to use angularJS personally/professionally, I thought I'd write a simple directive to render card text and casting cost. Pretty much just made the repo, so I still need to do examples/instructions (and frankly the css could be better), but it can be found here: https://github.com/omnihound/magic-symbol-directive
Well, it would make caching a bit better. Eg.: someone visit an other mtgimg user's site, then he visit mine, the browser can use the same set icons on my site from the cache. It's a tiny factor, but well its useful.
Also, can you please add Expire headers to the images? Google's analysis tool (PageSpeed insights) keeps bugging me because there is no expire time set on the images.
That css is really cool! Much better than my old img way.
Thanks! I originally stole it from here (http://bluebones.net/2013/10/css-sprite-for-magic-the-gathering-mana-symbols/), but it didn't have a tap symbol so I resized BaconCatBug's png. I was sort of surprised no one else out there had done it.
I had no time for optimisations like this. Just direct-linked the mana symbols with an img tag from gatherer.
Whoops!
It used to have one, but I must have made a change at some point and it must have gotten lost.
I have fixed it, and now the images have a far-future expires date.
Thanks for letting me know
All cards in the 'extras' files now have 'originalText' and 'originalType' fields. These contain the original non-oracle text and type that was on the card at the time it was printed.
Also updated all cards in all sets so that they have the latest oracle text, oracle type and rulings.
Enjoy
I have a lot of set's info in this way:
All sets up to Gatecrash in XMLs. My friend did this for me a while back. (It was costed me some money...) I can voluntary give this info for you if you can add it. The developers/designers are mapped into their own xml files (developers.xml and designers.xml). The flavors and other texts come from wizard's set info. (http://www.wizards.com/magic/tcg/productarticle.aspx?x=mtg/tcg/gatecrash/productinfo) The foreign language flavors was not added because the was unneeded at that time and would cost a lot of effort to add correctly. Also the intropacks/eventdecks missing sadly.
Hello
Thanks for the offer to provide more set info. At this time I'm not sure how much more set info I want to add. I originally wanted to focus mostly on just the cards. I'll need to think a bit about how much data I want to add to the sets
Okey, no problem. What I need is a big, robust MTG database at this point. At the moment the data for this comes from various sources (mtgjson, my xmls and so on). I like the life simple so using one datasource would be a lot easier, and maybe someone else want to use this stuff too. If you ever plan to implement this setinfo just write me a PM.
Could you post your XML files so that we could at least take a look? I'm a contributor to the SlightlyMagic.net pictures project and documenting things accurately is always an interest of ours
Also, about the "Promo Set for Gatherer": you might not want to include this set. It's not even a real thing, I'm not sure why it even exists in Gatherer. It looks like it contains all the old book promos like Mana Crypt, which is nice (obviously you can't just leave these cards out of a database), but then it also has all the prerelease cards up into Fifth Dawn for some reason. Have you considered doing anything about this?
Up to this point I've made sure that the MTGJSON set names match exactly what Gatherer uses.
When 'Magic 2015' is released, we will see whether they drop the 'Core Set' suffix from 'Magic 2014' or not.
It's possible they have decided to just start adding 'Core Set' suffix to all core sets going forward, and they started with 'Magic 2014'.
We'll see in July
For now, I'm going to keep the set names as they are.
You are correct that the 'Promo Set for Gatherer' is a bit of a mess. It doesn't even have all the promo cards, not even close. Gatherer also doesn't update it as far as I can tell.
I added the set and cards because I had multiple requests to do so.
I'd rather leave the data up, rather than take it down as people do use it, despite it's issues.
The data isn't harming anyone, as you easily enough choose to ignore that set